v1.9.24 - Refactor: GzipSink: optimized addSlice#139
Merged
Conversation
- `GZipSink`: - Added override for `addSlice` to handle partial chunk addition and update `_inputLength` accordingly. - Optimized `addSlice` to call `_gzipSink.close()` when `isLast` is true and full chunk is added. - `BytesSink`: - Updated `addSlice` to use new `addPart` method for partial chunk addition. - `BytesBuffer`: - Added `addPart` method to add a slice of bytes from a given offset and length, resizing buffer if needed. - Refactored `add` method to delegate to `addPart`. - Improved buffer range setting to support offset and length parameters in `addPart`.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #139 +/- ##
=======================================
Coverage 65.49% 65.49%
=======================================
Files 62 62
Lines 20991 21000 +9
=======================================
+ Hits 13748 13754 +6
- Misses 7243 7246 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GZipSink:addSliceto handle partial chunk addition and update_inputLengthaccordingly.addSliceto call_gzipSink.close()whenisLastis true and full chunk is added.BytesSink:addSliceto use newaddPartmethod for partial chunk addition.BytesBuffer:addPartmethod to add a slice of bytes from a given offset and length, resizing buffer if needed.addmethod to delegate toaddPart.addPart.